Always Run Staticcheck workflow #4690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: c-kruse <[email protected]>
c-kruse
force-pushed
the
Always-Run-Staticcheck
branch
from
4683cce to
e6a8620
Compare
echlebek
approved these changes
Apr 13, 2022
c-kruse
added a commit
that referenced
this pull request
May 19, 2022
Signed-off-by: c-kruse <[email protected]> (cherry picked from commit 4d01e5b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
The github workflows syntax for branch filtering is odd (glob-y not regex-y) so filtering to
branches: *does not match target branches with a slash in them likedevelop/6Why is this change necessary?
See #4689 as an example of a PR where staticcheck was not ran due to this filter.
Does your change need a Changelog entry?
No
Do you need clarification on anything?
No
Were there any complications while making this change?
No
Have you reviewed and updated the documentation for this change? Is new documentation required?
N/A
How did you verify this change?
See above
Is this change a patch?
N