Fake event module result #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative solution is presented in #185 |
Sensu Go backend processes events in asynchronous fashion, which makes
it almost impossible to retrieve the processed event shortly after it
has been sent to the backend.
Currently, after we submit an event, we query the backend for the last
event. What we get back is one of the following three options:
1. nothing, if our event is the first event ever and the backend did
not manage to process it yet;
2. previous event, if there is at least one preexisting event on the
backend and our event has not been processed yet;
3. our actual event, if the backend processed our event fast enough.
In the real world setting, the third scenario almost never happens,
which means that our event module is returning bogus results most of
the time.
To rectify the situation, we now simply return back the payload we sent
to the backend. This ensures that we return back relevant pieces of
information instead of some random or event or even none.
tadeboro
force-pushed
the
fake-object-in-event-module
branch
from
e66e3e9 to
25925ef
Compare
|
We decided to go through the deprecation cycle with the result modification. This PR introduces the deprecation and a temporary workaround, and we repurposed the #185 to clean the deprecation and remove the object result field. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensu Go backend processes events in an asynchronous fashion, which makes it almost impossible to retrieve the processed event shortly after it has been sent to the backend.
Currently, after we submit an event, we query the backend for the last event. What we get back is one of the following three options:
In the real world setting, the third scenario almost never happens, which means that our event module is returning bogus results most of the time.
To rectify the situation, we now simply return back the payload we sent to the backend. This ensures that we return back relevant pieces of information instead of some random or event or even none.