[CVE-2017-8418] - updating rubocop dependency. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking Changes: - removed ruby `< 2.1` support Misc: - appeased the cops Signed-off-by: Ben Abrams <[email protected]>
jaredledvina
approved these changes
Mar 16, 2018
I feel you...I have done so many of them I am often on auto pilot, I don't even wait to see what it says is wrong and I just notice it and fix it before running rubocop... |
majormoses
added a commit
that referenced
this pull request
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes:
< 2.1supportMisc:
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Address CVE, see parent issue for details
Known Compatibility Issues
removed ruby
< 2.1support