[CVE-2017-8418] - updating rubocop dependency. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
588099b
to
f654d14
Compare
Misc: - appeasing the cops Signed-off-by: Ben Abrams <[email protected]>
majormoses
force-pushed
the
fix/CVE-2017-8418
branch
from
f654d14
to
4f00a43
Compare
|
There is currently a backlog on travis-ci, will check back later butI tagged and it should be released when the backlog is cleared: released: https://rubygems.org/gems/sensu-plugins-opsgenie/versions/4.1.1 |
|
Had to re-start the jobs on travis, confirmed it's released now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc:
Signed-off-by: Ben Abrams [email protected]
Pull Request Checklist
sensu-plugins/community#77
General
Update Changelog following the conventions laid out here
Update README with any necessary configuration snippets
Binstubs are created if needed
RuboCop passes
Existing tests pass
Purpose
Update dependency to address a minor CVE
Known Compatibility Issues
None, while there were cops that could have been addressed in a breaking change fashion I decided to create TODOs and disable the rules inline to be addressed in the future.