Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metrics #3

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Added metrics #3

merged 1 commit into from
Apr 19, 2018

Conversation

yuri-zubov
Copy link
Contributor

@yuri-zubov yuri-zubov commented Apr 16, 2018

Pull Request Checklist

Is this in reference to an existing issue?

General

  • Update Changelog following the conventions laid out on Keep A Changelog

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

test

bundle exec metrics-gluster-peer-status.rb
yuri.gluster.ea79a5ef-909a-456d-8862-40705229e06c.state 3 1523711211
yuri.gluster.ea79a5ef-909a-456d-8862-40705229e06c.connected 1 1523711211
yuri.gluster.2999285c-465b-4b5b-be5d-888c122e1089.state 3 1523711211
yuri.gluster.2999285c-465b-4b5b-be5d-888c122e1089.connected 1 1523711211
bundle exec metrics-gluster-volume-info.rb
yuri.gluster.main.name main 1523711249
yuri.gluster.main.status 1 1523711249
yuri.gluster.main.statusStr Started 1523711249
yuri.gluster.main.snapshotCount 0 1523711249
yuri.gluster.main.brickCount 3 1523711249
yuri.gluster.main.distCount 3 1523711249
yuri.gluster.main.stripeCount 1 1523711249
yuri.gluster.main.replicaCount 3 1523711249
yuri.gluster.main.arbiterCount 0 1523711249
yuri.gluster.main.disperseCount 0 1523711249
yuri.gluster.main.redundancyCount 0 1523711249
yuri.gluster.volumes.count 1 1523711249
bundle exec metrics-gluster-volume-status.rb
yuri.gluster.main.nodeCount 3 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.status 1 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.sizeTotal 1099242147840 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.sizeFree 511644418048 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.blockSize 4096 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.inodesTotal 536870400 1523711372
yuri.gluster.main.node.fs02.adm.actility.com.inodesFree 535234418 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.status 1 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.sizeTotal 1099242147840 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.sizeFree 511042080768 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.blockSize 4096 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.inodesTotal 536870400 1523711372
yuri.gluster.main.node.fs03.adm.actility.com.inodesFree 535234332 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.status 1 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.sizeTotal 1099242147840 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.sizeFree 511104032768 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.blockSize 4096 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.inodesTotal 536870400 1523711372
yuri.gluster.main.node.fs01.adm.actility.com.inodesFree 535303323 1523711372
bundle exec metrics-gluster-volume-profile.rb -N main
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1.reads 1285 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1.writes 5148 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2.reads 1 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2.writes 284 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4.reads 145 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4.writes 37790 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8.reads 859 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8.writes 5052586 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16.reads 3403 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16.writes 27232 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.32.reads 9080 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.32.writes 52302 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.64.reads 21795 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.64.writes 217028 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.128.reads 144807 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.128.writes 622580 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.256.reads 19234 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.256.writes 177330 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.512.reads 27939 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.512.writes 314060 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1024.reads 32682 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1024.writes 878755 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2048.reads 129866 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2048.writes 1166091 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4096.reads 125289 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4096.writes 5809128 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8192.reads 133901 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8192.writes 5452006 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16384.reads 292822 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16384.writes 50277558 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.32768.reads 515980 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.32768.writes 8870592 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.65536.reads 1682612 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.65536.writes 10090330 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.131072.reads 35042400 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.131072.writes 27284238 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.262144.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.262144.writes 3801 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.524288.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.524288.writes 1834 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1048576.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1048576.writes 1276 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2097152.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2097152.writes 719 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4194304.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.4194304.writes 654 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8388608.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.8388608.writes 683 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16777216.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.16777216.writes 1094 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.33554432.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.33554432.writes 1479 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.67108864.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.67108864.writes 219 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.134217728.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.134217728.writes 396 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.268435456.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.268435456.writes 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.536870912.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.536870912.writes 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1073741824.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.1073741824.writes 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2147483648.reads 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.block.size.2147483648.writes 0 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STAT.hits 188889412 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STAT.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STAT.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STAT.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READLINK.hits 10653023 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READLINK.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READLINK.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READLINK.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKNOD.hits 11796 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKNOD.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKNOD.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKNOD.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKDIR.hits 255 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKDIR.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKDIR.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.MKDIR.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.UNLINK.hits 37591 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.UNLINK.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.UNLINK.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.UNLINK.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RMDIR.hits 178236123 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RMDIR.avgLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RMDIR.minLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RMDIR.maxLatency 0.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SYMLINK.hits 152 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SYMLINK.avgLatency 6027.973684 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SYMLINK.minLatency 119.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SYMLINK.maxLatency 353845.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RENAME.hits 312562 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RENAME.avgLatency 467.442379 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RENAME.minLatency 84.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RENAME.maxLatency 3420072.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LINK.hits 1603 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LINK.avgLatency 752.887087 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LINK.minLatency 76.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LINK.maxLatency 466317.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.TRUNCATE.hits 193697 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.TRUNCATE.avgLatency 98.790887 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.TRUNCATE.minLatency 58.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.TRUNCATE.maxLatency 362622.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPEN.hits 27809990 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPEN.avgLatency 188.950022 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPEN.minLatency 31.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPEN.maxLatency 4591583.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READ.hits 38223213 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READ.avgLatency 385.780477 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READ.minLatency 18.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READ.maxLatency 1617232.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.WRITE.hits 116347193 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.WRITE.avgLatency 168.309432 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.WRITE.minLatency 27.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.WRITE.maxLatency 4523698.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STATFS.hits 891000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STATFS.avgLatency 48.935882 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STATFS.minLatency 16.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.STATFS.maxLatency 53629.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FLUSH.hits 30876500 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FLUSH.avgLatency 38.093383 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FLUSH.minLatency 5.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FLUSH.maxLatency 236908.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSYNC.hits 811974 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSYNC.avgLatency 20613.345603 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSYNC.minLatency 23.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSYNC.maxLatency 4913387.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETXATTR.hits 941222 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETXATTR.avgLatency 1453.109809 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETXATTR.minLatency 36.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETXATTR.maxLatency 2876489.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.GETXATTR.hits 1092416 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.GETXATTR.avgLatency 1757.806267 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.GETXATTR.minLatency 5.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.GETXATTR.maxLatency 3000493.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.REMOVEXATTR.hits 801778 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.REMOVEXATTR.avgLatency 2186.874191 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.REMOVEXATTR.minLatency 21.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.REMOVEXATTR.maxLatency 2918088.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPENDIR.hits 79165814 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPENDIR.avgLatency 58.873318 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPENDIR.minLatency 1.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.OPENDIR.maxLatency 2914188.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.CREATE.hits 5300774 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.CREATE.avgLatency 275.058057 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.CREATE.minLatency 108.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.CREATE.maxLatency 3912150.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FTRUNCATE.hits 1128851 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FTRUNCATE.avgLatency 2077.003482 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FTRUNCATE.minLatency 32.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FTRUNCATE.maxLatency 4257723.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSTAT.hits 11358493 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSTAT.avgLatency 58.891216 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSTAT.minLatency 11.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FSTAT.maxLatency 271779.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LK.hits 129408 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LK.avgLatency 38.060259 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LK.minLatency 17.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LK.maxLatency 14767.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LOOKUP.hits 851965719 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LOOKUP.avgLatency 252.814219 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LOOKUP.minLatency 7.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.LOOKUP.maxLatency 4723521.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIR.hits 462007 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIR.avgLatency 2060.384306 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIR.minLatency 16.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIR.maxLatency 2648620.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.INODELK.hits 11814166 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.INODELK.avgLatency 2034.040633 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.INODELK.minLatency 9.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.INODELK.maxLatency 4531297.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FINODELK.hits 15331360 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FINODELK.avgLatency 356.281243 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FINODELK.minLatency 7.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FINODELK.maxLatency 2373606.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.ENTRYLK.hits 27878991 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.ENTRYLK.avgLatency 262.978975 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.ENTRYLK.minLatency 7.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.ENTRYLK.maxLatency 3494146.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.XATTROP.hits 2160878 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.XATTROP.avgLatency 3930.979918 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.XATTROP.minLatency 49.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.XATTROP.maxLatency 3994649.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FXATTROP.hits 15590351 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FXATTROP.avgLatency 468.522554 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FXATTROP.minLatency 37.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.FXATTROP.maxLatency 1838193.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RCHECKSUM.hits 604678 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RCHECKSUM.avgLatency 7676.975441 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RCHECKSUM.minLatency 31.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.RCHECKSUM.maxLatency 5642409.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETATTR.hits 3149277 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETATTR.avgLatency 2048.149656 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETATTR.minLatency 26.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.SETATTR.maxLatency 4381543.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIRP.hits 25983158 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIRP.avgLatency 591.630874 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIRP.minLatency 23.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.READDIRP.maxLatency 2413907.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.IPC.hits 272 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.IPC.avgLatency 12.753676 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.IPC.minLatency 6.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.fop.name.IPC.maxLatency 135.000000 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.duration 4141905 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.totalRead 4141905 1523711323
yuri.gluster.fs01.adm.actility.com:/data/brick0.totalWrite 4141905 1523711323

sensu-plugins/community#97
sensu-plugins/community#77

Copy link
Member

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think it looks good just some minor tweaks.

if value.is_a? Hash
print_hash(value, new_path)
else
output "#{config[:scheme]}#{new_path}", value unless value.nil? || value.empty?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should return false so that people can potentially rescue on it.

end
end

def array_to_naming_hash(array, key_name, only = nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only is a bit ambiguous and should be renamed to something like filter_keys.

@yuri-zubov
Copy link
Contributor Author

@majormoses - fixed

@majormoses majormoses merged commit 428812b into sensu-plugins:master Apr 19, 2018
@majormoses
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants