Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/license url override #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pymenguy
Copy link

@pymenguy pymenguy commented Nov 7, 2024

Hello,

When testing the capabilities of the tool, I noticed the URL could not be overridden by the option "override-package-information".

For many reasons URLs may be broken (domain name changing/expiring, changing SCM provider, etc). If we were to attempt the download of the original license, it would fail.

One such package I encountered is SharpDX, which still has the invalid URL linked on nuget.org :

Following what was written in #53 and #68 I also added the LicenceUrl to the list of fields and to the tests.

Copy link

sonarcloud bot commented Nov 7, 2024

@sensslen sensslen self-requested a review November 7, 2024 15:46
Copy link
Owner

@sensslen sensslen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. Would you mind adding a test that verifies that the LicenseUrl ends up in the override package information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants