Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve logout logic #982

Closed
libpitt opened this issue Oct 17, 2023 · 1 comment · Fixed by #983 or #984
Closed

Resolve logout logic #982

libpitt opened this issue Oct 17, 2023 · 1 comment · Fixed by #983 or #984
Assignees

Comments

@libpitt
Copy link
Contributor

libpitt commented Oct 17, 2023

Currently, the logout functionality on the portal is not making any requests. Resolve.

@libpitt
Copy link
Contributor Author

libpitt commented Oct 17, 2023

Findings

From ingest-api a redirect(globus_logout_url) is being made. But this is insufficient to correctly log user out of Globus.

after doing whatever cleanup it needs to do (e.g., delete access tokens), it should redirect the user’s web browser

According to Globus' docs, it is required that the user's browser is redirected to the logout page so that cookies etc can be cleared.

The content on https://auth.globus.org/v2/web/logout has restrictions, and unfortunately a strategy like using a hidden iframe to log user out while keeping them on SenNet UI also doesn't work.

Making fetch or vanilla XMLHttpRequest request to the logout URL also does not log user out completely from Globus. However, making a simple GET request to the URL with an API testing tool, does log the user out completely. Probably can investigate more or just keep with the Globus logout confirmation page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant