Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more use cases for adding attachments #858

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

cesargamboa
Copy link
Contributor

Added use cases for adding attachments and encode to base 64. From a local PDF file and using an URL (this example was tested using an AWS S3 bucket URL)

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • [x ] I have added inline documentation to the code I modified

Short description of what this PR does:

  • Added use cases for reading, encoding PDF. Also using an URL.

If you have questions, please send an email to SendGrid, or file a Github Issue in this repository.

Added use cases for adding attachments  and encode to base 64. From a local PDF file and using an URL (this example was tested using an AWS S3 bucket URL)
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Dec 12, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Dec 12, 2018

CLA assistant check
All committers have signed the CLA.

@childish-sambino childish-sambino changed the title attachments.md docs: add more use cases for adding attachments Jun 30, 2020
@childish-sambino childish-sambino merged commit 9275f9d into sendgrid:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants