Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#629 Documentation updated for from field #768

Merged
merged 1 commit into from
Oct 10, 2018
Merged

#629 Documentation updated for from field #768

merged 1 commit into from
Oct 10, 2018

Conversation

valerianpereira
Copy link
Contributor

@valerianpereira valerianpereira commented Oct 4, 2018

Resolves #629 documentation update for from field usage / implementation variations.

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Documentation updated to add a sample snippet for from field customization.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

#629  Documentation updated for `from` field usage / implementation variations.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 4, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@reedsa reedsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, thanks!

@reedsa reedsa added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 4, 2018
@valerianpereira
Copy link
Contributor Author

valerianpereira commented Oct 5, 2018

Thanks @reedsa for reviewing the PR.

@reedsa / @thinkingserious - The travis-ci check says pending on this PR. However, on the details page it says successful. Is it alright?

@reedsa
Copy link
Contributor

reedsa commented Oct 5, 2018

Not sure why GH was out of sync but just kicked it and things are ready to merge. I've added the deploy label so it should be merged soon! Thanks again.

@thinkingserious thinkingserious added hacktoberfest difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code labels Oct 10, 2018
@thinkingserious
Copy link
Contributor

Hello @valerianpereira,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit dcd0930 into sendgrid:master Oct 10, 2018
@thinkingserious
Copy link
Contributor

Hello @valerianpereira,

Thanks again for the PR!

We noticed that you have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@valerianpereira
Copy link
Contributor Author

valerianpereira commented Oct 27, 2018

@thinkingserious I was not aware of this already.
Nevermind I will get started.

@thinkingserious
Copy link
Contributor

Hello @valerianpereira,

Thanks again for the PR!

You have earned 1 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support for fromname
4 participants