Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription-widget node engine version #754

Conversation

rafaelalmeidatk
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.

If you execute lerna bootstrap it will try to install subscription-widget and it will fail:

lerna ERR! yarn install --mutex network:42424 --non-interactive stderr:
warning Waiting for the other yarn instance to finish (5655)
warning Waiting for the other yarn instance to finish (5674)
error @sendgrid/[email protected]: The engine "node" is incompatible with this module. Expected version "4.1.1".
error Found incompatible module

This is due the node version being locked to a old version of node (4.1.1). This PR changes the node version to be compatible with all the other packages (>=6.0.0)

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@rafaelalmeidatk rafaelalmeidatk changed the title Fix subscription widget node engine Fix subscription-widget node engine version Oct 2, 2018
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @rafaelalmeidatk,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit bfc8451 into sendgrid:master Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @rafaelalmeidatk,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@thinkingserious
Copy link
Contributor

Hello @rafaelalmeidatk,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants