Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription widget to packages #539

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Add subscription widget to packages #539

merged 1 commit into from
Oct 28, 2017

Conversation

devchas
Copy link
Contributor

@devchas devchas commented Oct 24, 2017 •
edited by mbernier
Loading

Added the entire subscription widget found here to a sub-directory within packages. This would ultimately need to be converted to a package

@mbernier edit:
solves #473

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 24, 2017
@devchas devchas mentioned this pull request Oct 24, 2017
Closed
@mbernier mbernier added difficulty: hard fix is hard in difficulty hacktoberfest difficulty: very hard fix is very hard in difficulty and removed difficulty: hard fix is hard in difficulty labels Oct 24, 2017
@mbernier mbernier merged commit d737914 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @devchas,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: very hard fix is very hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devchas @thinkingserious @mbernier