add heroku tutorial #468
add heroku tutorial #468
Conversation
thinkingserious
added
the
status: code review request
|
|
|
signed license agreement |
thinkingserious
added
difficulty: medium
|
@sw-yx Can you please look into the conflicts and merge them? Sorry we haven't gotten to this just yet - we are moving through everything as quickly as possible! |
|
We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt. Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!) You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged. |
|
ok sure. I think i resolved all conflicts btw! |
|
Nice, thanks! |
package-lock.json
Outdated
| @@ -5546,6 +5546,12 @@ | |||
| "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=", | |||
| "dev": true | |||
| }, | |||
| "typescript": { | |||
There was a problem hiding this comment.
Not sure why this was added to this commit. Was this a mistake?
|
Could you please review my requested changes so that I can get this merged? :) Thanks! With Best Regards, Elmer |
|
Hey Elmer sorry for the delay in reply. holiday :) i was a noobie back then and commited the package lock change. i have undone that now, thank you. |
|
Hello @sw-yx, |
as requested in #463