Create a PULL_REQUEST_TEMPLATE #315
Conversation
thinkingserious
added
the
status: code review request
|
|
.github/PULL_REQUEST_TEMPLATE
Outdated
|
|
||
| If you have questions, please send an email [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository. | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
We appreciate this, but it's going to show up on every pull request. Can you please remove this comment?
@ksigler7 -- Are you cool with that?
There was a problem hiding this comment.
@mbernier Sure, I'll go ahead and remove the comment if @ksigler7 is okay with it.
There was a problem hiding this comment.
@nishithshah2211 yeah, no worries on removing it! Thanks for asking!
.github/PULL_REQUEST_TEMPLATE
Outdated
|
|
||
| Fill out this form in the body: | ||
| --> | ||
|
|
There was a problem hiding this comment.
Can you please also add
Closes: #[Issue number]
.github/PULL_REQUEST_TEMPLATE
Outdated
|
|
||
| If you have questions, please send an email [Sendgrid](mailto:[email protected]), or file a Github Issue in this repository. | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
We added this in our template, and it's been really useful because it triggers githubs functionality to automatically close the issue when the pull request is merged:
<!--
If this pull request closes an issue, add in the issue number here
-->
Closes #
Add a template for describing the change(s) being done.
|
@mbernier @ksigler7 Does it look good now? |
|
@nishithshah2211 - looks good to me! |
|
@mbernier Should I make any more changes? |
|
Thanks for your work here @nishithshah2211 |
|
Hello @nishithshah2211, |
Created a PULL_REQUEST_TEMPLATE for description of changes based on the link to the template given in #314