forked from redis/redis-py
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GROW-3134] release already acquired connections, when get_connections raised an exception #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zach-iee
changed the title
[GROW-3134] release already acquired connections, when get_connection…
[GROW-3134] release already acquired connections, when get_connections raised an exception
Jun 27, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3 +/- ##
==========================================
+ Coverage 92.10% 92.32% +0.21%
==========================================
Files 119 119
Lines 30547 30567 +20
==========================================
+ Hits 28136 28221 +85
+ Misses 2411 2346 -65
☔ View full report in Codecov by Sentry. |
…s raised an exception
bellatoris
approved these changes
Jun 28, 2023
zach-iee
added a commit
that referenced
this pull request
Aug 21, 2023
…s raised an exception (#3) * [GROW-3134] release already acquired connections, when get_connections raised an exception * fix style
zach-iee
added a commit
that referenced
this pull request
Aug 21, 2023
…s raised an exception (#3) * [GROW-3134] release already acquired connections, when get_connections raised an exception * fix style
zach-iee
added a commit
that referenced
this pull request
Sep 14, 2023
…s raised an exception (#3) * [GROW-3134] release already acquired connections, when get_connections raised an exception * fix style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
when writing test for a custom patch that we've made, i found out that we may be leaking connections in the below scenario
In the above scenario, the connection on node 1 that we've acquired doesn't get released forever as we lose reference to the connection, when an exception is raised
FYI there may be more connection leaks, but we need to monitor after this gets applied
Please provide a description of the change here.