Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Calculations to DX #2600

Open
wants to merge 37 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

toropok
Copy link
Contributor

@toropok toropok commented Jul 29, 2024

Description of the issue/feature this PR addresses

This PR migrates the AT Calculation to Dexterity for Python 3 compatibility.

Current behavior before PR

Calculation is a content type based on the Archetypes framework

Desired behavior after PR is merged

Calculation is a content type based on the Dexterity framework

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@toropok toropok marked this pull request as ready for review November 18, 2024 14:11
@toropok
Copy link
Contributor Author

toropok commented Nov 18, 2024

Hi @ramonski @xispa,

Here's my preliminary delivery for the calc migration! 😊 This migration turned out to be quite a tough nut compared to the previous ones—no chance it would’ve worked without the invaluable help of @Bugerman58! 🚀

Currently, we’re stuck at a point where the tests are failing. Specifically:

We’re not using HistoryAwareReferenceField as expected.
Was there any thought about using an alternative?
Or is there no longer a need to maintain version references?
Looking forward to your input!

@ramonski
Copy link
Contributor

ramonski commented Nov 19, 2024

Hi Leonid, hi Anton,
many thanks for your continuous efforts and support that we really appreciate!
Yes, indeed, you picked a tough nut with the calculations 🤯
Regarding the HistoryAwareReferenceWidget, Jordi and I discussed once that we want to drop it and maybe lookup the values from the Snapshot storage? And even combine this with our UIDReferenceField?
Anyhow, we'll find a solution for this for sure.
Thanks again for your good work and we'll review as soon as possible!

@xispa
Copy link
Member

xispa commented Nov 20, 2024

Excellent work @toropok and @Bugerman58 🥇 . I can imagine how challenging the migration of Calculation has been!. Your amazing work is really appreciated! Willing to review the Pull Request already and maybe we open another one later for the removal of the HistoryAware relic!

@xispa xispa added Cleanup 🧹 Code cleanup and refactoring Content Migration ♻️ Migrate contents to Dexterity labels Nov 20, 2024
@xispa xispa self-requested a review November 26, 2024 08:51
@xispa
Copy link
Member

xispa commented Nov 26, 2024

Hi @toropok , tests are failing https://github.com/senaite/senaite.core/actions/runs/11948903328/job/33307294669

Can you please take a look before I start to review?

@toropok
Copy link
Contributor Author

toropok commented Nov 26, 2024

Hi @toropok , tests are failing https://github.com/senaite/senaite.core/actions/runs/11948903328/job/33307294669

Can you please take a look before I start to review?

Hi @xispa

Sure, I'll fix the failed Python tests (they only test object validation) and get back to you. The remaining failing tests are doctests, which are related to HistoryAwareReferenceField.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup 🧹 Code cleanup and refactoring Content Migration ♻️ Migrate contents to Dexterity
Development

Successfully merging this pull request may close these issues.

3 participants