-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Calculations to DX #2600
base: 2.x
Are you sure you want to change the base?
Conversation
Here's my preliminary delivery for the calc migration! 😊 This migration turned out to be quite a tough nut compared to the previous ones—no chance it would’ve worked without the invaluable help of @Bugerman58! 🚀 Currently, we’re stuck at a point where the tests are failing. Specifically: We’re not using HistoryAwareReferenceField as expected. |
Hi Leonid, hi Anton, |
Excellent work @toropok and @Bugerman58 🥇 . I can imagine how challenging the migration of Calculation has been!. Your amazing work is really appreciated! Willing to review the Pull Request already and maybe we open another one later for the removal of the |
Hi @toropok , tests are failing https://github.com/senaite/senaite.core/actions/runs/11948903328/job/33307294669 Can you please take a look before I start to review? |
Hi @xispa Sure, I'll fix the failed Python tests (they only test object validation) and get back to you. The remaining failing tests are doctests, which are related to HistoryAwareReferenceField. |
Description of the issue/feature this PR addresses
This PR migrates the AT Calculation to Dexterity for Python 3 compatibility.
Current behavior before PR
Calculation is a content type based on the Archetypes framework
Desired behavior after PR is merged
Calculation is a content type based on the Dexterity framework
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.