Add COPY button on AST panel and AST breakpoint #27
Conversation
nnpvaan-infostatus
force-pushed
the
ast-panels-and-breakpoints-duplicate
branch
from
11afacd
to
3376e76
Compare
There was a problem hiding this comment.
Thanks @nnpvaan-infostatus , I have left some comments. Please, simplify the _call_ function from DuplicateView
|
|
||
| <metal:content-core fill-slot="content-core"> | ||
| <span class="text-danger" tal:condition="python:not view.objects" i18n:translate=""> | ||
| No AST Breakpoint were selected. |
There was a problem hiding this comment.
Better No AST Breakpoints tables were selected
| class="text-muted text-secondary" | ||
| i18n:translate="" | ||
| tal:condition="python:view.objects"> | ||
| Enter the details of each of the AST Breakpoint you want to copy. |
There was a problem hiding this comment.
Enter the details for each AST Breakpoints table you want to copy
| class="text-muted text-secondary" | ||
| i18n:translate="" | ||
| tal:condition="python:view.objects"> | ||
| Enter the details of each of the AST Panel you want to copy. |
There was a problem hiding this comment.
Enter the details for each AST panel you want to copy
|
|
||
| <metal:content-core fill-slot="content-core"> | ||
| <span class="text-danger" tal:condition="python:not view.objects" i18n:translate=""> | ||
| No AST Panel were selected. |
| <table class="table table-borderless table-hover"> | ||
| <tr class="border-bottom"> | ||
| <th>AST Panel</th> | ||
| <th>Title</th> |
There was a problem hiding this comment.
Missing i18n:translate attribute:
<th i18n:translate="">AST Panel</th>
<th i18n:translate="">Title</th>| <table class="table table-borderless table-hover"> | ||
| <tr class="border-bottom"> | ||
| <th>AST Breakpoint</th> | ||
| <th>Title</th> |
There was a problem hiding this comment.
Missing i18n:translate attribute:
<th i18n:translate="">AST Breakpoints table</th>
<th i18n:translate="">Title</th>
src/senaite/ast/view.py
Outdated
| """Checks if the given title is valid and unique. Returns an | ||
| error message if not valid. None otherwise | ||
| """ | ||
| import pdb;pdb.set_trace() |
src/senaite/ast/view.py
Outdated
| titles = self.request.form.get("title", []) | ||
| self.created = [] | ||
| for i, s in enumerate(sources): | ||
| if not titles[i]: |
There was a problem hiding this comment.
This if not titles[i] condition can be moved to the logic where you check if the title exists, inside copy_object function, so the whole loop becomes simpler:
self.savepoint = savepoint()
self.created = []
uids = self.request.form.get("uids", [])
titles = self.request.form.get("title", [])
for index, uid in enumerate(uids):
title = titles[index]
obj = self.copy_object(uid, title)
if not obj:
self.savepoint.rollback()
self.created = []
break
self.created.append(title)Note that if the system cannot create an object (e.g. because the title exists or no title was set), the whole transaction is rolled back, so all objects created previously are dismissed. This guarantees that objects are only created if all them have "valid" information.
src/senaite/ast/view.py
Outdated
| return | ||
|
|
||
| # Create a copy | ||
| return api.copy_object(source, title=title, ShortTitle="") |
There was a problem hiding this comment.
You can remove ShortTitle, cause this field belongs to Analysis-like objects only:
return api.copy_object(source, title=title)
src/senaite/ast/view.py
Outdated
| """Creates a copy of the given object, but with the given title | ||
| """ | ||
| # Validate the title | ||
| portal_type = get_portal_type(get_object(source)) |
There was a problem hiding this comment.
Better use api explicitely, like api.get_portal_type and api.get_object
Description of the issue/feature this PR addresses
Add COPY button in AST breakpoint table page and AST panel page
Linked issue: https://github.com/beyondessential/pnghealth.lims/issues/288
Current behavior before PR
AST breakpoint and AST panel page don't have the "Duplicate" button
Desired behavior after PR is merged
When the "Duplicate" button is clicked, the system displays a new view where the user can set the values Title
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.