Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AST entry is empty when analyses categorization for sample is checked #21

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

xispa
Copy link
Member

@xispa xispa commented Mar 11, 2023

Description of the issue/feature this PR addresses

This Pull Request ensures that the listing for results entry is not empty when the setting Categorize sample analyses introduced with senaite/senaite.core#2140 is selected

Current behavior before PR

The listing for the introduction of AST results is empty when the setting Categorize sample analyses from setup is selected

Captura de 2023-03-11 19-14-30

Desired behavior after PR is merged

The listing for the introduction of AST results is not empty when the setting Categorize sample analyses from setup is selected

Captura de 2023-03-11 19-13-28

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@xispa xispa changed the title Fix listing for AST results entry is empty when categories for sample is enabled Fix AST entry is empty when analyses categorization for sample is checked Mar 11, 2023
@xispa xispa requested a review from ramonski March 11, 2023 18:14
@xispa xispa added the bug Something isn't working label Mar 11, 2023
@ramonski ramonski merged commit dc7e232 into master Mar 11, 2023
@ramonski ramonski deleted the compat-core-2140 branch March 11, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants