Refactor transaction result code #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orogvany
approved these changes
Nov 3, 2018
| @@ -742,13 +742,13 @@ protected Block proposeBlock() { | |||
| long t1 = TimeUtil.currentTimeMillis(); | |||
|
|
|||
| // fetch pending transactions | |||
| final List<PendingManager.PendingTransaction> pending = pendingMgr | |||
| final List<PendingManager.EvaluatedTransaction> pending = pendingMgr | |||
There was a problem hiding this comment.
For VM calls, I'm not sure that 'evaluatedTransaction' really describes their state at this point. They've been checked for only the most minimal of validation, since we cannot do the same early validation as we do as basic transaction types.
| break; | ||
| } | ||
| if (value.lt(config.minDelegateBurnAmount())) { | ||
| result.setError(Error.INVALID_DELEGATE_BURN_AMOUNT); | ||
| result.setCode(Code.INVALID_BURNING_AMOUNT); |
There was a problem hiding this comment.
I think I prefer keeping Delegate in the code variable name, since the act they're doing is registering a delegate, the burning is just a side effect.
| return this == FAILURE; | ||
| } | ||
|
|
||
| public boolean isAccepted() { |
There was a problem hiding this comment.
It's strange to have isAccepted() and isRejected()
Would suggest at minimum to make isAccepted() return !isRejected() or vice versa, rather than have 2 separate implementations for maintenance purposes.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.