Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: Remove fee for VM calls #117

Merged
merged 5 commits into from
Jan 29, 2019

Conversation

orogvany
Copy link
Collaborator

@orogvany orogvany commented Dec 18, 2018

Update API to reflect

Fixes #100

Update API to reflect
to ensure tx marshalls correctly, use 0 for fee.
@orogvany orogvany requested a review from semuxgo January 14, 2019 06:31
Also bump min gas fee
@honeycrypto
Copy link
Contributor

This didn't pass my tests. I cannot synchronise Testnet from block 0. Once it arrives to the first CREATE/CALL which had some fee already, synchronisation stops with this in the log:

WARN     Block            Transaction result does not match for TransactionResult [code=INVALID_FEE, returnData=, # logs=0]
ERROR    SemuxSync        Invalid transactions
INFO     SemuxSync        Invalid block

I am at develop branch with the latest commit from RC2 PR #112

@orogvany
Copy link
Collaborator Author

Ah good call. For early blocks,a fee is permissible. Will remove check there

@orogvany orogvany merged commit 50ed1a6 into semuxproject:develop Jan 29, 2019
@orogvany orogvany deleted the remove_fee_from_vm branch January 29, 2019 16:48
@semuxgo semuxgo mentioned this pull request Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants