Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console window does not support parameters with spaces/quotes #13

Closed
orogvany opened this issue Jun 16, 2018 · 3 comments
Closed

Console window does not support parameters with spaces/quotes #13

orogvany opened this issue Jun 16, 2018 · 3 comments
Assignees
@orogvany
Labels
enhancement An enhancement to existing implementation
Milestone
v2.0.0

Comments

@orogvany
Copy link
Collaborator

orogvany commented Jun 16, 2018 •
edited
Loading

As you can use the API to create/interact with items requiring spaces (signMessage, etc)
The console window should support tokenizing based on quoted blocks of text

We should also support escaped quotes, so signMessage "hello \"world\"" should parse
@semuxgo semuxgo added this to the v1.3.0 milestone Jul 28, 2018
@semuxgo semuxgo added the enhancement An enhancement to existing implementation label Jul 28, 2018
@semuxgo semuxgo modified the milestones: v1.3.0, v1.4.0 Aug 11, 2018
@semuxgo semuxgo modified the milestones: v1.4.0, v1.5.0 Jun 28, 2019
@semuxgo
Copy link
Contributor

semuxgo commented Jul 4, 2019

Any plan on improving this?

@orogvany
Copy link
Collaborator Author

orogvany commented Jul 4, 2019

Yes, this kinda fell off my radar

orogvany added a commit to orogvany/semux-core that referenced this issue Jul 5, 2019
@orogvany
GUI: Allow quotes in console dialog
a8dc9b3 
Tested with quotes and escaped quotes.

Fixes semuxproject#13
@orogvany orogvany mentioned this issue Jul 5, 2019
Merged
@orogvany
Copy link
Collaborator Author

orogvany commented Jul 5, 2019

#203 merged, fixed.

@orogvany orogvany closed this as completed Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orogvany orogvany

Labels
enhancement An enhancement to existing implementation
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
2 participants
@orogvany @semuxgo