Use IS_CONSTRUCTOR instead of CONSTRUCTORS #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @alex-konovalov this appears to be failing because of the use of |
|
@alex-konovalov any chance you could rebase this against stable-3.0? Then I can merge it, and release 3.0.13. |
CONSTRUCTORS has been removed from the GAP master branch.
olexandr-konovalov
force-pushed
the
alex-konovalov-patch-1
branch
from
96e6a73
to
bd3344f
Compare
|
@james-d-mitchell now submitted against stable-3.0 |
|
@alex-konovalov one last thing (hopefully), can you bump the required version of Digraphs to 0.12.0, then the tests should pass, except maybe because of Issues #450 and/or #444. |
|
Done. Let's see if tests will pass, then I may squash it in a single commit, if you prefer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONSTRUCTORS has been removed from the GAP master branch: see gap-system/gap@b597f5c