Use GAP kernel helper IS_STRING_REP to test for strings

There are actually six TNUMs indicating strings.
semigroups · Nov 7, 2024 · c69be74 · c69be74
1 parent 265de04
commit c69be74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/gapbind14/include/gapbind14/to_cpp.hpp b/gapbind14/include/gapbind14/to_cpp.hpp
@@ -86,7 +86,7 @@ namespace gapbind14 {
     static gap_tnum_type constexpr gap_type = T_STRING;
 
     std::string operator()(Obj o) const {
-      if (TNUM_OBJ(o) != T_STRING) {
+      if (!IS_STRING_REP(o)) {
         throw std::runtime_error(std::string("expected string, found ")
                                  + TNAM_OBJ(o));
       }

diff --git a/src/to_cpp.hpp b/src/to_cpp.hpp
@@ -388,7 +388,7 @@ namespace gapbind14 {
     static gap_tnum_type constexpr gap_type = T_STRING;
 
     cpp_type operator()(Obj o) const {
-      if (TNUM_OBJ(o) != T_STRING && TNUM_OBJ(o) != T_STRING + IMMUTABLE) {
+      if (!IS_STRING_REP(o)) {
         ErrorQuit("expected string but got %s!", (Int) TNAM_OBJ(o), 0L);
       }
       std::string stype = std::string(CSTR_STRING(o));
@@ -409,7 +409,7 @@ namespace gapbind14 {
     using cpp_type = libsemigroups::Congruence::options::runners;
 
     cpp_type operator()(Obj o) const {
-      if (TNUM_OBJ(o) != T_STRING && TNUM_OBJ(o) != T_STRING + IMMUTABLE) {
+      if (!IS_STRING_REP(o)) {
         ErrorQuit("expected string but got %s!", (Int) TNAM_OBJ(o), 0L);
       }
       std::string stype = std::string(CSTR_STRING(o));