Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant rules for HTML templates #3349

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

inkz
Copy link
Member

@inkz inkz commented Apr 10, 2024

@p4p3r
Copy link
Contributor

p4p3r commented Apr 11, 2024

@inkz javascript.express.security.audit.xss.ejs.var-in-href.var-in-href is another "duplicate", and the generic rule should match also *.ejs files.

@inkz
Copy link
Member Author

inkz commented Apr 12, 2024

@p4p3r as far as I remember it uses regex and is intended to work on a different syntax. so the generic rule is not gonna work on it.
Mustache {{ foobar }}
EJS <%= foobar %>

Copy link
Contributor

@p4p3r p4p3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@p4p3r p4p3r merged commit aa55fb5 into develop Oct 24, 2024
8 checks passed
@p4p3r p4p3r deleted the inkz/var-in-href-fix branch October 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants