Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point gc-stats to fork with custom binary URI #51

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Point gc-stats to fork with custom binary URI #51

merged 1 commit into from
Oct 13, 2022

Conversation

PabloB94
Copy link
Member

No description provided.

@PabloB94 PabloB94 merged commit 9afc22f into master Oct 13, 2022
@PabloB94 PabloB94 deleted the pbc_SC-14550_fix_gc-stats_missing branch October 13, 2022 16:01
otisg
otisg reviewed Oct 13, 2022
View reviewed changes
Copy link
Member

@otisg otisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, this is a Pablo-fork? Can't use the Sematext-fork?
Just wondering if we are creating more future maintenance mess?

@PabloB94
Copy link
Member Author

This is a temporary Pablo-fork that I intend to get rid of asap by asking Adnan to merge. It seems like GitHub changed some paths for downloads and it broke the package published on npm, so I patched it quickly for one of our users, but it's not going to stay like this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otisg otisg otisg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloB94 @otisg