Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes to process metrics #22

Merged
merged 42 commits into from
Jan 22, 2020
Merged

Added fixes to process metrics #22

merged 42 commits into from
Jan 22, 2020

Conversation

adnanrahic
Copy link
Contributor

@megastef I've added the pidusage-tree module to this PR and added tests to make sure it works. We have some strange behavior with not gathering child_process metrics for CPU, memory, and uptime.

TODO:
Figure out why gathering child_process metrics is failing.

@adnanrahic adnanrahic requested a review from megastef December 23, 2019 15:48
@adnanrahic
Copy link
Contributor Author

This should now be a stable version that will gather and ship metrics. What is yet to be done is to check out the rollup function in the chartbuilder and figure out how it works. There seems to be some strange behavior there.

@emir-arnautovic
Copy link

Rollup function can be set explicitly in chart definition or implicitly by setting metric type (gauge or counter) in metric meta info.

@adnanrahic adnanrahic changed the base branch from fix_process_metrics to master December 24, 2019 13:09
@adnanrahic
Copy link
Contributor Author

Update: We have an issue with the child_process tags. For some reason, they are not sent. I'm debugging why.

@adnanrahic
Copy link
Contributor Author

Update: Fixed by adding process.name tag to add a grouping method for child processes. This feature is ready.
Todo: Need to sync with team regarding which tag names to use. Halting progress on this PR until then.

@adnanrahic
Copy link
Contributor Author

Adding a list of tag names and metric names for reference (this will be changed in the near future):

Tags:

  • process.pid
  • process.ppid
  • nodejs.process.type
  • nodejs.process.name

Metrics:

  • nodejs.process.count
  • nodejs.process.uptime
  • nodejs.process.cpu.percent
  • nodejs.process.memory

@adnanrahic adnanrahic merged commit f3176b7 into master Jan 22, 2020
@adnanrahic adnanrahic deleted the fix_process_metrics_2 branch January 22, 2020 15:02
@adnanrahic adnanrahic mentioned this pull request Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants