-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tags in filters #3
Comments
"taggable" may not be the most intuitive word choice here. It implies one can add tags, but this is really about filtering by column value, not tagging. Unfortunately, don't have a better suggestion right now. |
Yeah, I'm bugged by it as well. I'll think about other naming options when I'm done with the implementation. |
In the jQuery world, they used to call those tags |
This is about filtering by column value, so filterable would be a better name. |
We already have |
I assumed the existing option was more about "search", because the matching is a little lose (any substring, right?), while "filter" could imply "exact match". I was going to suggest an alternative -- suggestible -- but that actually means "easily influenced" in English. My thinking was that columns marked as such would be the ones that can be suggested in the filter field... |
Also rename: values -> filterValues, getValueTitle -> getFilterTitle, getValueLabel -> getFilterLabel, getValueClassName -> getFilterClassName
Ok, I've made some changes, and we now use:
|
Also rename: values -> filterValues, getValueTitle -> getFilterTitle, getValueLabel -> getFilterLabel, getValueClassName -> getFilterClassName
Also rename: values -> filterValues, getValueTitle -> getFilterTitle, getValueLabel -> getFilterLabel, getValueClassName -> getFilterClassName
[#3] Add support for tags in filters
User must be able to filter the table by selecting predefined tags in the filter. By default, the tags must be generated from the provided data by taking unique values for each column that is marked as taggable.
The tags must be auto-completed while user is typing, and the tags should be displayed in the form of "ColumnName:TagValue".
taggable: true
in the column definition.tags: ['value1', 'value2']
in the column definition.The text was updated successfully, but these errors were encountered: