Skip to content

Commit

Permalink
Fix test because hostname changed
Browse files Browse the repository at this point in the history
  • Loading branch information
@AkhigbeEromo
AkhigbeEromo committed Oct 23, 2024
1 parent 683b038 commit a8346ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion exporter/sematextexporter/writer_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ func TestSematextHTTPWriterBatchEnqueuePointEmptyTagValue(t *testing.T) {
require.NoError(t, err)

if assert.NotNil(t, recordedRequest) {
expected := "m,k=v,os.host=ADMINs-MacBook-Pro.local,token=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx f=1i 1628605794318000000"
expected := "m,k=v,os.host=Mac,token=xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx f=1i 1628605794318000000"
assert.Equal(t, expected, strings.TrimSpace(string(recordedRequestBody)))
}
}
Expand Down

2 comments on commit a8346ed

@otisg
Copy link
Member

@otisg otisg commented on a8346ed Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can't have a test that depends on the hostname, @Eromosele-SM

@Eromosele-SM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True,
I realized this, cause hostname is subject to change
At that time i just wanted to ensure that host name was also being passed in the metrics line with the token because of how important it is to SC

Please sign in to comment.