Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli templates #830

Merged
merged 6 commits into from
Jul 19, 2024
Merged

fix: cli templates #830

merged 6 commits into from
Jul 19, 2024

Conversation

vplasencia
Copy link
Member

Description

This PR:

  • Fixes the monorepo-ethers and monorepo-subraph templates because they were not working properly due to missing React Hook dependencies.

  • Update the Readme file of the 3 CLI templates.

Related Issue(s)

Closes #829

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner July 19, 2024 12:44
cedoor
cedoor approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a tip

packages/cli-template-contracts-hardhat/README.md Outdated Show resolved Hide resolved
@vplasencia vplasencia requested a review from cedoor July 19, 2024 13:02
@cedoor cedoor merged commit af4fe8d into main Jul 19, 2024
5 checks passed
@cedoor cedoor deleted the fix/cli-templates branch July 19, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor Awaiting requested review from cedoor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix CLI templates
2 participants
@vplasencia @cedoor