Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readme #11

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Improve readme #11

merged 7 commits into from
Oct 13, 2023

Conversation

uscholdm
Copy link
Collaborator

@uscholdm uscholdm commented Oct 5, 2023

Fixes #10. Fixes #13

  • Greatly improved the README file and tweaked a few annotations.
  • Fixed an import statement.
  • Only importing versionIRIs.
  • Added example annotations

@uscholdm uscholdm requested a review from rjyounes October 5, 2023 00:59
README.md Outdated
1. the version of a disease ontology being at least 3.1.0 and less than 4.0.0.
2. the version of gist core being between at least 12.1.0 and less than 13.0.0.

The need for such specifying such dependencies arises when ontologies use terms from imported ontologies.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The need for such specifying such dependencies arises when ontologies use terms from imported ontologies.
The need for specifying such dependencies arises when ontologies use terms from imported ontologies.

README.md Outdated

The need for such specifying such dependencies arises when ontologies use terms from imported ontologies.

Three SPARQL queries are provided of perform the following tasks:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Three SPARQL queries are provided of perform the following tasks:
Three SPARQL queries are provided to perform the following tasks:

examples/examplesVersionDependency.ttl Outdated Show resolved Hide resolved
examples/examplesVersionDependency.ttl Show resolved Hide resolved
@uscholdm uscholdm marked this pull request as draft October 12, 2023 16:57
@uscholdm uscholdm requested a review from rjyounes October 12, 2023 16:57
Copy link
Contributor

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let's go back to what you had previously on line 28, given the best practice decided on today.

examples/examplesVersionDependency.ttl Show resolved Hide resolved
@uscholdm uscholdm requested a review from rjyounes October 12, 2023 20:44
@uscholdm uscholdm marked this pull request as ready for review October 12, 2023 20:45
@uscholdm uscholdm requested a review from sa-bpelakh October 12, 2023 20:48
@@ -25,13 +25,13 @@
a owl:Ontology ;
owl:imports
<https://ontologies.exco.com/exeoDiseases> ,
<https://w3id.org/semanticarts/ontology/gistCore12.1.0> ,
<https://w3id.org/semanticarts/ontology/gistCore> ,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said we should use versioned IRIs for imports.

examples/examplesVersionDependency.ttl Outdated Show resolved Hide resolved
Copy link
Contributor

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge.

@uscholdm uscholdm merged commit 09b43ed into develop Oct 13, 2023
@uscholdm uscholdm deleted the improve-readme branch October 13, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import versioned IRI of the operators ontology Improve README file
2 participants