Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement versioning ontology per issue 979 #982

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rjyounes
Copy link
Collaborator

Fixes #979.

@rjyounes rjyounes marked this pull request as draft October 12, 2023 18:47
@rjyounes
Copy link
Collaborator Author

Putting into draft state - forgot to check documentation for necessary updates.

@rjyounes
Copy link
Collaborator Author

This can't be finalized until #983 is complete, since the versioning and ops files can't be downloaded so the checks fail.

@rjyounes rjyounes marked this pull request as ready for review October 12, 2023 20:03
Copy link
Contributor

@uscholdm uscholdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one wording suggestion.

docs/release_notes/issue979-versioning Outdated Show resolved Hide resolved
@rjyounes rjyounes marked this pull request as draft October 13, 2023 13:11
@rjyounes
Copy link
Collaborator Author

Keeping in draft state until:

@rjyounes
Copy link
Collaborator Author

@sa-bpelakh @uscholdm Do you think it's necessary to state the version and dependencies in the ancillary ontologies as well as gistCore? It looks like a bit of overkill, and these ontologies are always versioned with gist and would likely not have dependencies different from gist's. On the other hand, for absolute correctness I suppose they are needed.

@pmcb55
Copy link

pmcb55 commented Oct 18, 2023

I'm just curious really - but in reference to 'absolute correctness' around dependencies, dependency ranges, and the like, did you folks look into PLOW? (As indeed, I think 'absolute correctness' is definitely a most worthy goal, as dependency issues have a very nasty habit of getting convoluted/unwieldy/nightmarish pretty quickly once out in the 'real-world'.)

@sa-bpelakh sa-bpelakh self-assigned this Jan 11, 2024
@rjyounes
Copy link
Collaborator Author

Moved to 12.2.0

@rjyounes
Copy link
Collaborator Author

@sa-bpelakh: @uscholdm has raised the point that you should make sure this implementation doesn't clash with the new units and magnitudes model (shouldn't, because there is no dependency on gist, but worth checking).

@uscholdm
Copy link
Contributor

uscholdm commented Sep 10, 2024

This can't be finalized until #983 is complete, since the versioning and ops files can't be downloaded so the checks fail.

@rjyounes @Jamie-SA
The operators file can now be downloaded, so the import should work. However, the versioning ontology is not currently downloadable.

From Protege,

Possible fixes (one or both):

The first fix is already implemented on the develop branch of the versioning ontology and should be ready for releasing a new version, 1.0.1 or 1.1.0. The only 'semantic' change is the explicit import of operators1.0.0 instead of operators.

QUESTION: do we have a consistent policy on what to do with loading ontologies from URL when using a 'main URI' vs. a versioned IRI? If so, then we should make the imports of the following work:

@uscholdm
Copy link
Contributor

Keeping in draft state until:

@rjyounes This has now been merged.

@uscholdm
Copy link
Contributor

@sa-bpelakh: @uscholdm has raised the point that you should make sure this implementation doesn't clash with the new units and magnitudes model (shouldn't, because there is no dependency on gist, but worth checking).

I checked, there is no conflict, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Implement versioning ontology
4 participants