Issue #1155 Annotations conform to style guide #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This set of changes focuses on removing excess information from skos:definition and moving it to skos:example or skos:scopeNote. There is also some reformatting of these three annotations.
rjyounes
requested changes
Sep 17, 2024
rjyounes
reviewed
Sep 17, 2024
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
Co-authored-by: Rebecca Younes <[email protected]>
uscholdm
requested changes
Sep 20, 2024
There was a problem hiding this comment.
Overall this is excellent, a big job and a painstaking one. I did make a bunch of suggestions.
Although this exercise was specifically to align definition style, I often gave in to the temptation to fix a bad definition, which might instead have been a separate issue warranting a group discussion.
I made changes for properties to style starting with 'relates'. But there were too many to attempt a fix for all of them.
dylan-sa
requested changes
Sep 23, 2024
Co-authored-by: Michael Uschold <[email protected]> Co-authored-by: dylan-sa <[email protected]>
uscholdm
reviewed
Sep 24, 2024
Co-authored-by: Rebecca Younes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes focuses on removing excess information from
skos:definitionand moving it toskos:exampleorskos:scopeNote. There is also some reformatting of all three annotations. However these changes do not attempt to makeskos:definitionfull sentences where they are not. More changes will be added for this.The definitions most significantly affected by removing examples are
gist:Behaviorandgist:Content.gist:Behaviormaybe falls in the category "Occasionally a definition can hardly be understood at all without an example" of the style guide. My recommendation is that we try to make a more specific, full sentence definition, but we may determine that it is most clear to simply add the example back to the definition.Our definition of
gist:Content, in my opinion, was not a definition but rather a list of examples. I attempted to make a new definition, but would appreciate input on if this matches the existing usage. If there is other history on this definition and why we should include examples in the definition, that would also be helpful.