Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeletal definitions for SKOS terms #1027

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

dylan-sa
Copy link
Contributor

Adding skeletal definitions for SKOS terms. Omitting definitions for SHACL terms in anticipation of #1001.

Closes #934.

@dylan-sa dylan-sa requested review from rjyounes and marksem January 25, 2024 16:55
@dylan-sa dylan-sa self-assigned this Jan 25, 2024
@dylan-sa
Copy link
Contributor Author

Looks like the skeletal definitions are violating our prefLabel requirement. An easy solution is to add prefLabels. Another option is to tweak the SHACL and add an exception for the skeletal definitions.

@rjyounes
Copy link
Collaborator

Does the non-conforming label approach work here, or is some label required even if the format is not conformant?

@rjyounes
Copy link
Collaborator

My preference would be to tweak the shacl so that it only applies to terms in the gist namespace.

@dylan-sa
Copy link
Contributor Author

@rjyounes @marksem -- I have tweaked the SHACL to target only classes/properties in the gist namespace.

gistCore.ttl Show resolved Hide resolved
validation/shapes/ontologyShapes.ttl Outdated Show resolved Hide resolved
validation/shapes/ontologyShapes.ttl Outdated Show resolved Hide resolved
@dylan-sa dylan-sa requested a review from rjyounes February 1, 2024 19:06
@dylan-sa
Copy link
Contributor Author

dylan-sa commented Feb 1, 2024

@rjyounes -- Thanks for review. I have pushed changes to address comments.

Copy link
Collaborator

@rjyounes rjyounes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one question. Once you've clarified it, I'll approve.

@rjyounes rjyounes self-requested a review February 8, 2024 16:13
@rjyounes rjyounes merged commit 0cfda0e into develop Feb 8, 2024
1 check passed
@rjyounes rjyounes deleted the dabney/934-skeletal-definitions-for-DL branch February 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Add skeletal definitions of SKOS and SHACL terms used in gist in order to achieve DL-compliance
3 participants