Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gist:ContemporaneousEvent incorrect rdfs:comment #174

Closed
marksem opened this issue Feb 13, 2020 · 4 comments · Fixed by #503
Closed

gist:ContemporaneousEvent incorrect rdfs:comment #174

marksem opened this issue Feb 13, 2020 · 4 comments · Fixed by #503
Assignees
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: implementation specified Implementation has been specified. A developer should be assigned.

Comments

@marksem
Copy link
Collaborator

marksem commented Feb 13, 2020

Comments says: "An event that actually started after the present time. When we record an end time it ceases to be contemporaneous"

Isn't this incorrect to say it started after? Isn't this supposed to be that it started before the current time, and is still ongoing?

@marksem marksem added the impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) label Feb 13, 2020
@uscholdm
Copy link
Contributor

Yeah, I think so. Good catch.

@marksem
Copy link
Collaborator Author

marksem commented Jun 1, 2021

@rjyounes , bringing this back to our awareness. Fix should just be changing comment to something like:
"An event that actually started before the present time. When we record an end time it ceases to be contemporaneous."

@rjyounes
Copy link
Collaborator

rjyounes commented Jun 1, 2021

I've put this on the June project to get it back on our radar.

Comments:

  • I recommend changing the name altogether. "Contemporaneous" refers to TWO times that occur at the same time. I have not seen any dictionary that defines it as contemporaneous with the current time without explicitly specifying that. How about CurrentEvent? (Note: this promotes the fix from a patch to a minor change (with deprecation of the current term), or major if we include it in 10.0.0 and remove the current term altogether.)
  • The contemporaneous event could have started before or at the current moment in time. (I guess this is a quibble since as soon as we've recorded that start time it's already in the past.)
  • The contemporaneous event ceases to be contemporaneous only if the recorded end time is before the current time. If it is a future time we would still refer to it as contemporaneous.

I've added some additional questions related to our Event class hierarchy in #489. We may want to consider these in tandem, or we may want to address this smaller issue first and the larger issues in #489 later.

@rjyounes
Copy link
Collaborator

DECISION: Change definition now, leave naming question till later. This may end up being removed due to lack of use.

@rjyounes rjyounes added the status: implementation specified Implementation has been specified. A developer should be assigned. label Jun 24, 2021
sa-bpelakh added a commit that referenced this issue Jul 14, 2021
…-136-171-174

Addressing multiple issues for v10.0.0. Fixes #126, #136, #171, #174.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: patch No new functionality or changes in human-readable semantics (e.g,. fixing a typo in an annotation) status: implementation specified Implementation has been specified. A developer should be assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants