-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"BREAKING CHANGE:" and "!" after type not properly triggering major release #231
Comments
Okay, read up on conventional commits and tried the Full configuration available in |
I also managed to overcome this issue by adjusting header by adding exclamation mark to type/scope and adding Example commit - Fail
Based on Conventional Commit standard / Angular JS project standard, I applied both of the specified formats for triggering a release - type/scope and footer. Then got it to work successfully. I think it's fair to close this issue and rather bring up a discussion in the conventional commits standard community. It does feel a bit strange though that the commit analyzer is sensitive to whether there is an exclamation mark and whether it is upper or lower case, etc. I wouldn't be opposed to the idea of the tool providing some smart assistance to the developer. Possibly, using some wiggle room to complement the standard's specifications. Example commit - succeeded
Log output in pipeline:
Dependencies include: .releaserc.json
|
@alehar9320 that's not going to work regardless since you need Regardless, it's not well documented, and seems to not be working properly as according to the Angular preset. Little mystified here. If you try a commit message like this, it should work (assuming
|
Adding my +1 here. According to the Conventional Commits spec, adding only the exclamation mark after the From Conventional Commits 1.0.0:
|
@darrylhodgins experiencing this too |
Any update on this ? |
I encountered this issue too. |
Here's a workaround. Put this in the [
'@semantic-release/commit-analyzer',
{
preset: 'conventionalcommits',
},
],
[
'@semantic-release/release-notes-generator',
{
preset: 'conventionalcommits',
}
], You need to use Then install |
I did a deep dive on this and think the way it is, is counterintuitive when expecting Conventional Commits 1.0.0 to apply. However as the default ruleset/parserConfig is using conventional-changelog-angular and the corresponding commit message guidelines of angular do not adhere to the rule declaring breaking changes by exclamation mark like: As @aleclarson noted, if you want to apply the rules of the conventional commits spec, then you can configure that as the preset to use. If this should be fixed in the angular rules, it needs to be done in the conventional-changelog angular parser options by introducing: breakingHeaderPattern: /^(\w*)(?:\((.*)\))?!: (.*)$/, As in the parser options of convetional commits. Another but different discussion is, if the default ruleset of the commit-analyzer should be switched from angular to conventional-commits, as people (me included) were/are expecting adherence to those specifications. |
semantic-release/commit-analyzer#231 BREAKING CHANGE: show commit 8a4ec01 (8a4ec01)
Please add some support to at least to override this option |
Setting |
If using the |
This workaround doesn't work for me. |
I've seen the other issues like this that are already closed (#108)! But I believe this is different.
BREAKING CHANGE:
appears at the beginning of the footer, yet the release is only minor.Here's the output from https://github.com/dgattey/dg/runs/2444677702?check_suite_focus=true
The text was updated successfully, but these errors were encountered: