Added a clearCache method to clear the render cache #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianreavis
added a commit
that referenced
this pull request
Jun 1, 2014
Added a clearCache method to clear the render cache
|
Excellent addition! Thanks, Derek. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue while using selectize where I wanted to render options based on the value set in a previous selectize (e.g. when a school course is chosen, show the times for that course). Calling refreshOptions wouldn't re-render the options because they were cached. I had to clear the renderCache manually, then the render function would get called next time the list was opened.
If this is expected behavior, I think providing a documented method to do so might be clearer. If this doesn't fit in with the intentions of selectize, feel free to close the PR or post any changes you'd like me to make.