Updated measureString to return 0 for an empty string. #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In autoGrow, track the input's current width in a closure rather than using jQuery .width() to see if the width needs updating.
brianreavis
added a commit
that referenced
this pull request
Feb 10, 2014
Updated measureString to return 0 for an empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My app was using a lot (100+) of selectize controls on a page and autoGrow / measureString was a significant bottleneck.
An easy fix was to have measureString avoid actually measuring when not necessary (i.e. empty string).
I also keep track of the current width of the input in the autoGrow closure to avoid having to measure the width before updating it, as that was also slowing down initialization.