Feature clear button #1872
Merged
Feature clear button #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
risadams
reviewed
Sep 22, 2022
src/plugins/clear_button/plugin.js
Outdated
| { | ||
| title: "Clear", | ||
| className: "clear", | ||
| libelle: "×", |
There was a problem hiding this comment.
yes, sure , sorry keep the same doctrine
risadams
reviewed
Sep 22, 2022
docs/plugins.md
Outdated
| @@ -13,7 +13,7 @@ complete control. | |||
| - All plugins live in their own folders in ["src/plugins"](../src/plugins). | |||
| - Plugin names should be in follow the format: `/[a-z_]+$` | |||
| - JS source should live in a "plugin.js" file (required). | |||
| - CSS should live in a "plugin.less" file (optional). It will be bundled at build time. | |||
| - CSS should live in a "plugin.scss" file (optional) and include it into `src/scss/selectize.scss`. It will be bundled at build time. | |||
There was a problem hiding this comment.
For compatibility with the older versions of bootstrap, there should be both a sass and less version of styles.
This might change in the future if we decide to drop support for older versions, but there is enough of a user base that still does use older versions that we should try to support them where possible
There was a problem hiding this comment.
sure, misstake, I thought it had not been updated, I had trouble finding what I was missing to use my SCSS file
risadams
suggested changes
Sep 22, 2022
risadams
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New plugin
clear_buttondisplaying a button for clear input value(s)Add two examples for
clear buttonrendering (simple and multiple select)Update doc for plugins (using SCSS instead LESS)
Don't hesitate to tel me any bad move or any improvement