Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Access to portal warp command locked behind wrong perm #275

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

sekwah41
Copy link
Owner

@sekwah41 sekwah41 commented Jun 30, 2021

What Changed

The issue is with the current perm its both for the internal command code and spigot's system. So you get too much access.

📦 Published PR to discord as canary version: 0.7.0--canary.275.895fcc6

@sekwah41 sekwah41 added the release Create a release when this pr is merged label Jun 30, 2021
@sekwah41
Copy link
Owner Author

Will be merged once its tested by the user which was having the issue.

@Kamryx
Copy link

Kamryx commented Jun 30, 2021

So, here's the series of events:

I downloaded the new jar, typed the command, as you can see it auto predicts so it's properly registered, keep in mind i already had advancedportals.warp.warzone granted.
image

This is the response I then got, same as before.
image

I then made the following changes just to see if that changed anything:
image

And then got this:
image

@sekwah41
Copy link
Owner Author

Remember to replace your username for this

but if you run the following commands

/luckperms user sekwah41 permission check advancedportals.warp.warzone
/luckperms user sekwah41 permission check advancedportals.warp

What are the outputs?

@sekwah41 sekwah41 merged commit e73d84a into spigot-1.13-1.16 Jun 30, 2021
@github-actions
Copy link
Contributor

🚀 PR was released in v0.7.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jun 30, 2021
@sekwah41 sekwah41 deleted the fix/warp-perms branch June 30, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants