fix: Permission Tag (#418)

sekwah41 · May 12, 2024 · 669d050 · 669d050
1 parent c2360ee
commit 669d050
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/core/src/main/java/com/sekwah/advancedportals/core/tags/activation/PermissionTag.java b/core/src/main/java/com/sekwah/advancedportals/core/tags/activation/PermissionTag.java
@@ -55,11 +55,11 @@ public String description() {
 
     @Override
     public boolean preActivated(TagTarget target, PlayerContainer player, ActivationData activeData, String[] argData) {
-        if (target instanceof AdvancedPortal portal) {
-            var portalName = portal.getName();
-            if (!player.hasPermission(argData[0])) return false;
-            }
-        return false;
+        if (!player.hasPermission(argData[1])) {
+            player.sendMessage(Lang.translate("portal.error.nopermission"));
+            return false;
+        }
+        return true;
     }
 
     @Override

diff --git a/lang/src/main/resources/lang/en_GB.lang b/lang/src/main/resources/lang/en_GB.lang
@@ -126,6 +126,7 @@ portal.error.takenname= The name given for the portal is already taken.
 portal.error.selection.differentworlds= Both the selected points need to be in the same world.
 portal.error.selection.missing= You need to select both points for the portal.
 portal.error.save= There was a problem saving the portal.
+portal.error.nopermission=You don't have permission to use that portal.
 
 portal.nobuild= You don't have permission to build here!