Update to Discount 2.2.7d #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The discount library fails to compile with GCC 14. The author of the library has already fixed the issue for discount v3.0.0+[1], but upgrading would require adjusting to some significant API changes. This commit applies a patch provided by Atri Bhattacharya for OpenSUSE[1] and also used by Gentoo.[2] 1: Orc/discount#283 2: https://bugs.gentoo.org/894560
|
The following error occurred with the latest version on macOS Sequoia, and I can install it with this pull request branch. I hope it will be merged soon. cc -fPIC -Wno-implicit-int -I. -g -c main.c
main.c:311:29: error: incompatible function pointer types passing 'char *(char *, int, char *)' to parameter of type 'mkd_callback_t' (aka 'char *(*)(const char *, const int, void *)') [-Wincompatible-function-pointer-types]
311 | mkd_e_code_format(doc, external_codefmt);
| ^~~~~~~~~~~~~~~~
./mkdio.h:71:45: note: passing argument to parameter here
71 | void mkd_e_code_format(void*, mkd_callback_t);
| ^
1 error generated.
make[1]: *** [main.o] Error 1
make: *** [discount-2.2.7/libmarkdown.a] Error 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the latest maintenance release of discount v2 and apply a small patch to compile properly with GCC 14 and similar.