Skip to content

Commit

Permalink
[discover ]Adjust icon size to fix spacing in action table (opensearc…
Browse files Browse the repository at this point in the history
…h-project#8143)

Signed-off-by: Adam Tackett <[email protected]>
Co-authored-by: Adam Tackett <[email protected]>
  • Loading branch information
TackAdam and Adam Tackett authored Sep 11, 2024
1 parent 461a395 commit 84b3cf0
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import React from 'react';
import { FormattedMessage } from '@osd/i18n/react';
import { EuiToolTip, EuiSmallButtonIcon } from '@elastic/eui';
import { EuiToolTip, EuiButtonIcon } from '@elastic/eui';
import { i18n } from '@osd/i18n';

export interface Props {
Expand All @@ -53,7 +53,7 @@ export function DocViewTableRowBtnFilterAdd({ onClick, disabled = false }: Props

return (
<EuiToolTip content={tooltipContent}>
<EuiSmallButtonIcon
<EuiButtonIcon
aria-label={i18n.translate('discover.docViews.table.filterForValueButtonAriaLabel', {
defaultMessage: 'Filter for value',
})}
Expand All @@ -63,6 +63,7 @@ export function DocViewTableRowBtnFilterAdd({ onClick, disabled = false }: Props
onClick={onClick}
iconType={'magnifyWithPlus'}
iconSize={'s'}
size={'xs'}
/>
</EuiToolTip>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import React from 'react';
import { FormattedMessage } from '@osd/i18n/react';
import { EuiToolTip, EuiSmallButtonIcon } from '@elastic/eui';
import { EuiToolTip, EuiButtonIcon } from '@elastic/eui';
import { i18n } from '@osd/i18n';

export interface Props {
Expand Down Expand Up @@ -65,7 +65,7 @@ export function DocViewTableRowBtnFilterExists({

return (
<EuiToolTip content={tooltipContent}>
<EuiSmallButtonIcon
<EuiButtonIcon
aria-label={i18n.translate('discover.docViews.table.filterForFieldPresentButtonAriaLabel', {
defaultMessage: 'Filter for field present',
})}
Expand All @@ -75,6 +75,7 @@ export function DocViewTableRowBtnFilterExists({
disabled={disabled}
iconType={'indexOpen'}
iconSize={'s'}
size={'xs'}
/>
</EuiToolTip>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import React from 'react';
import { FormattedMessage } from '@osd/i18n/react';
import { EuiToolTip, EuiSmallButtonIcon } from '@elastic/eui';
import { EuiToolTip, EuiButtonIcon } from '@elastic/eui';
import { i18n } from '@osd/i18n';

export interface Props {
Expand All @@ -53,7 +53,7 @@ export function DocViewTableRowBtnFilterRemove({ onClick, disabled = false }: Pr

return (
<EuiToolTip content={tooltipContent}>
<EuiSmallButtonIcon
<EuiButtonIcon
aria-label={i18n.translate('discover.docViews.table.filterOutValueButtonAriaLabel', {
defaultMessage: 'Filter out value',
})}
Expand All @@ -63,6 +63,7 @@ export function DocViewTableRowBtnFilterRemove({ onClick, disabled = false }: Pr
onClick={onClick}
iconType={'magnifyWithMinus'}
iconSize={'s'}
size={'xs'}
/>
</EuiToolTip>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

import React from 'react';
import { FormattedMessage } from '@osd/i18n/react';
import { EuiToolTip, EuiSmallButtonIcon } from '@elastic/eui';
import { EuiToolTip, EuiButtonIcon } from '@elastic/eui';
import { i18n } from '@osd/i18n';

export interface Props {
Expand All @@ -42,7 +42,7 @@ export interface Props {
export function DocViewTableRowBtnToggleColumn({ onClick, active, disabled = false }: Props) {
if (disabled) {
return (
<EuiSmallButtonIcon
<EuiButtonIcon
aria-label={i18n.translate('discover.docViews.table.toggleColumnInTableButtonAriaLabel', {
defaultMessage: 'Toggle column in table',
})}
Expand All @@ -51,6 +51,7 @@ export function DocViewTableRowBtnToggleColumn({ onClick, active, disabled = fal
disabled
iconType={'tableOfContents'}
iconSize={'s'}
size={'xs'}
/>
);
}
Expand All @@ -63,7 +64,7 @@ export function DocViewTableRowBtnToggleColumn({ onClick, active, disabled = fal
/>
}
>
<EuiSmallButtonIcon
<EuiButtonIcon
aria-label={i18n.translate('discover.docViews.table.toggleColumnInTableButtonAriaLabel', {
defaultMessage: 'Toggle column in table',
})}
Expand All @@ -73,6 +74,7 @@ export function DocViewTableRowBtnToggleColumn({ onClick, active, disabled = fal
data-test-subj="toggleColumnButton"
iconType={'tableOfContents'}
iconSize={'s'}
size={'xs'}
/>
</EuiToolTip>
);
Expand Down

0 comments on commit 84b3cf0

Please sign in to comment.