Update LimitSimulationGasDecorator with custom Gas Meter Setter #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kbhat1
changed the title
Kbhat1
commented
Apr 15, 2024
| @@ -91,15 +91,15 @@ func TestGasCostOnQuery(t *testing.T) { | |||
| Depth: 1, | |||
| Work: 50, | |||
| }, | |||
| expectedGas: 2*GasWork50 + GasReturnHashed, | |||
| expectedGas: 2*GasWork50 + GasReturnHashed + 1, | |||
There was a problem hiding this comment.
Verifying this update
There was a problem hiding this comment.
do you mind shedding light as to why we expect 1 extra gas here?
There was a problem hiding this comment.
Fyi @philipsu522 @udpatil this feels like it may be unrelated to this PR and possible rounding issues. Check this comment from before: https://github.com/sei-protocol/sei-wasmd/blob/UpdateLimitSimulationGasDecorator/x/wasm/keeper/recurse_test.go#L248
Kbhat1
commented
Apr 15, 2024
| }, | ||
| "recursion 4, some work": { | ||
| gasLimit: 400_000, | ||
| msg: Recurse{ | ||
| Depth: 4, | ||
| Work: 50, | ||
| }, | ||
| expectedGas: 5*GasWork50 + 4*GasReturnHashed, | ||
| expectedGas: 5*GasWork50 + 4*GasReturnHashed + 1, |
There was a problem hiding this comment.
Verifying this update
philipsu522
reviewed
Apr 16, 2024
| @@ -91,15 +91,15 @@ func TestGasCostOnQuery(t *testing.T) { | |||
| Depth: 1, | |||
| Work: 50, | |||
| }, | |||
| expectedGas: 2*GasWork50 + GasReturnHashed, | |||
| expectedGas: 2*GasWork50 + GasReturnHashed + 1, | |||
There was a problem hiding this comment.
do you mind shedding light as to why we expect 1 extra gas here?
philipsu522
approved these changes
Apr 16, 2024
codchen
approved these changes
Apr 16, 2024
yzang2019
approved these changes
Apr 16, 2024
philipsu522
approved these changes
Apr 16, 2024
philipsu522
approved these changes
Apr 17, 2024
udpatil
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding sei-chain PR: sei-protocol/sei-chain#1546
TESTING