Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics labeling issue #225

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Fix metrics labeling issue #225

merged 1 commit into from
Apr 12, 2024

Conversation

yzang2019
Copy link
Contributor

Describe your changes and provide context

This PR fix an existing issue caused by previous commits after we added new metrics. Since we don't use labeling, we shouldn't add label to the metric definition.

Testing performed to validate your change

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 58.11%. Comparing base (5e8e9a2) to head (1635f94).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   57.81%   58.11%   +0.29%     
==========================================
  Files         249      249              
  Lines       34006    34006              
==========================================
+ Hits        19660    19761     +101     
+ Misses      12771    12681      -90     
+ Partials     1575     1564      -11     
Files Coverage Δ
internal/consensus/metrics.go 84.90% <ø> (ø)
internal/consensus/metrics.gen.go 13.96% <0.00%> (ø)
internal/state/metrics.gen.go 14.14% <0.00%> (ø)

... and 18 files with indirect coverage changes

@yzang2019 yzang2019 requested a review from stevenlanders April 12, 2024 07:12
@yzang2019 yzang2019 merged commit f49d0f6 into main Apr 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants