Add new endpoint to expose lag #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we add unit tests to |
philipsu522
approved these changes
May 17, 2023
There seems to be no easy way to test lag_status with unit test since we can't mock Reactor object. Just tested with integration test and works properly. |
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
## Describe your changes and provide context `seid status` fails for non-validator nodes. It turns out that the check for `ValidatorInfo.Pubkey` here https://github.com/cosmos/cosmos-sdk/blob/main/client/rpc/status.go#L52 isn't in our branch, which causes it to fail with a nil pointer. ## Testing performed to validate your change Verified and tested on rpc node: ``` /home/ubuntu/sei-chain# seid status | jq { "NodeInfo": { "protocol_version": { "p2p": "8", "block": "11", ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Problem:
AWS ELB/ALB required health check endpoint to respond a non 200 response to indicate the service is not healthy. This is currently not available for RPC nodes.
Solution:
We will add a new endpoint /lag_status, which will respond a 200 OK when lag is below lag-threshold, and will respond with a non 200 status code when lag is above the lag threshold. In that way, we can easily configure ALB to detect the health of an RPC node
Testing performed to validate your change