Revert block.Evidence to nested block.Evidence.Evidence #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCyson
changed the title
yzang2019
approved these changes
May 15, 2023
BrandonWeng
approved these changes
May 15, 2023
philipsu522
added a commit
that referenced
this pull request
May 17, 2023
This reverts commit 3558d87.
philipsu522
added a commit
that referenced
this pull request
May 17, 2023
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
## Describe your changes and provide context This PR adds eventMangaer to the mergeIterator to record resource access for READ operation that doesn't access to the cache iterator but the parent (often iavl) iterator. ## Testing performed to validate your change - Load test - Tested on local node - unit test Co-authored-by: Cyson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This change reverts https://github.com/tendermint/tendermint/pull/7765/files, which removes the nested Evidence layer.
By adding the
EvidenceDatalayer back, /block endpoint will returninstead of
Testing performed to validate your change