Do not run DBSync if there is already a readable app version #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
approved these changes
Apr 26, 2023
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
## Describe your changes and provide context Callers to `GetWasmDependencyAccessOps` now needs to pass in a `WasmMessageInfo` instead of raw message bytes so that the function can identify whether the message is a query or execute. This PR introduced helpers under `types/wasm.go` to help creating such `WasmMessageInfo`. `GetWasmDependencyAccessOps` would then extend the access operations list with the appropriate specific access ops. Next steps: - Add separate selector enums for query reference and execute reference - Handle new selector enums by passing the current WasmMessageInfo ## Testing performed to validate your change unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
If application DB already has a non-zero version (e.g. if the process restarts after DBSync finishes), we do not want to wipe out everything and rerun DBSync
Testing performed to validate your change
loadtest cluster