Add DBSync Module #118
Merged
Add DBSync Module #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony-chen-formalize-new-statesync
branch
from
5e2b9dc to
a53e57c
Compare
yzang2019
reviewed
Apr 21, 2023
| Height: r.config.TrustHeight, | ||
| Hash: r.config.TrustHashBytes(), | ||
| } | ||
| if err := r.waitForEnoughPeers(ctx, 2); err != nil { |
There was a problem hiding this comment.
Might be helpful to add some info logs before and after this
| @@ -1257,6 +1260,43 @@ func (cfg *InstrumentationConfig) ValidateBasic() error { | |||
| return nil | |||
| } | |||
|
|
|||
| type DBSyncConfig struct { | |||
| Enable bool `mapstructure:"db-sync-enable"` | |||
There was a problem hiding this comment.
Nice! Thanks for the changing the config name
| @@ -31,6 +32,7 @@ type Application interface { | |||
| OfferSnapshot(context.Context, *RequestOfferSnapshot) (*ResponseOfferSnapshot, error) // Offer a snapshot to the application | |||
| LoadSnapshotChunk(context.Context, *RequestLoadSnapshotChunk) (*ResponseLoadSnapshotChunk, error) // Load a snapshot chunk | |||
| ApplySnapshotChunk(context.Context, *RequestApplySnapshotChunk) (*ResponseApplySnapshotChunk, error) // Apply a shapshot chunk | |||
| LoadLatest(context.Context, *RequestLoadLatest) (*ResponseLoadLatest, error) | |||
There was a problem hiding this comment.
Can we add a small comment for what this interface do? Like the above ones?
config/config.go
Outdated
| SnapshotDirectory: "", | ||
| TimeoutInSeconds: 0, | ||
| NoFileSleepInSeconds: 5, | ||
| FileWorkerCount: 0, |
There was a problem hiding this comment.
Can we have better and more common defaults here? I'd suggest let's provide some ready to be used default value for:
- SnapshotInterval
- TimeoutInSeconds
- NoFileSleepInSeconds
- FileWorkerCount
- FileWorkerTimeout
- TrustPeriod
internal/dbsync/reactor.go
Outdated
| syncer := NewSyncer(logger, config, baseConfig, reactor.requestMetadata, reactor.requestFile, reactor.commitState, reactor.postSync) | ||
| reactor.syncer = syncer | ||
|
|
||
| reactor.BaseService = *service.NewBaseService(logger, "BlockSync", reactor) |
yzang2019
approved these changes
Apr 22, 2023
codchen
force-pushed
the
tony-chen-formalize-new-statesync
branch
from
6b5c89a to
37f0c27
Compare
codchen
force-pushed
the
tony-chen-formalize-new-statesync
branch
from
b1dba5b to
b03c748
Compare
codchen
force-pushed
the
tony-chen-formalize-new-statesync
branch
from
b03c748 to
78ec60b
Compare
Timwood0x10
pushed a commit
to Timwood0x10/sei-tendermint
that referenced
this pull request
Jun 7, 2023
## Describe your changes and provide context This adds the midblock interfaces and module manager functionality to sei-cosmos ## Testing performed to validate your change Added unit test for module manager behavior and also tested with local sei with sei-chain changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Added a new
internalmodule calleddbsyncthat enables syncing application DB files directly. Its discovery mechanism resembles that ofstatesyncwith some simplification. Still a WIPTesting performed to validate your change
unit tests
tested in loadtest cluster