Add unused prival pubKey back to node info #111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
TM 0.35 removes unused pubKey from
node.rpcEnv
and only validator nodes will returnvalidator_info
in the/status
tm rpc endpoint. This update, however, breaks many auxiliary packages' interface as they cannot correctly serialize the defaultvalidator_info.address
:TM 0.34:
TM 0.35:
=>
ERROR failed to spawn chain runtime: relayer error: RPC error to endpoint http://:26657/: serde parse error: expected 40-character hex string, got "" at line 1 column 1298
This PR reverts the change and add back the unused pubKey & address of any node type.
Note that the other option to fix the interface incompatibility is to add a default dummy address (a 40 character hex string), but that may be confusing for any future reader / relevant issue or error.
Testing performed to validate your change