Separate orphan storage #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
approved these changes
Jun 5, 2023
| @@ -951,12 +965,44 @@ func (tree *MutableTree) saveFastNodeVersion() error { | |||
| return tree.ndb.setFastStorageVersionToBatch() | |||
| } | |||
|
|
|||
| func (tree *MutableTree) handleOrphans(version int64) error { | |||
There was a problem hiding this comment.
is this function threadsafe?
There was a problem hiding this comment.
it's not threadsafe, but it would not run concurrently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add a new option that stores orphan separate from the main application data to maximize data locality for orphan data which, for a given version, is always read and written together. It also removes the need for expensive calls like
getPreviousVersionso that the overall latency is further improved.Specifically, if this option is on, orphan data would be stored as plain files cataloged by the committing version that resulted in the orphans, and also cached in memory. Most of the time, orphans will be read from the memory and used to delete obsolete data in the application DB, after which the corresponding orphan version directory will be removed as a whole. In the rare event of crash or process restarts, orphan data would be read from the orphan files.
Testing performed to validate your change
unit test & testing on atlantic-2