-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TxTracer
to DeliverTxEntry
which is the first step to support tracing when using OCC
#478
Merged
stevenlanders
merged 2 commits into
sei-protocol:seiv2
from
streamingfast:feature/occ-tx-tracer
Mar 29, 2024
Merged
Added TxTracer
to DeliverTxEntry
which is the first step to support tracing when using OCC
#478
stevenlanders
merged 2 commits into
sei-protocol:seiv2
from
streamingfast:feature/occ-tx-tracer
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoueh
force-pushed
the
feature/occ-tx-tracer
branch
from
March 29, 2024 13:59
8e22d1d
to
c7d62bc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #478 +/- ##
==========================================
+ Coverage 55.34% 55.35% +0.01%
==========================================
Files 629 629
Lines 53948 53963 +15
==========================================
+ Hits 29857 29872 +15
Misses 21957 21957
Partials 2134 2134
|
…rt tracing when using OCC This brings in an interface that can be set on `DeliverTxEntry` and hooks into the `scheduler` so it call's the necessary tracer callbacks when required. Refer to `types/tx_tracer.go` for extra details about the patch.
maoueh
force-pushed
the
feature/occ-tx-tracer
branch
from
March 29, 2024 15:31
b0b6e4f
to
92e6425
Compare
#477 Must be merged first other unit test of this PR are not going to pass properly. |
stevenlanders
approved these changes
Mar 29, 2024
## Describe your changes and provide context - Some tasks could be in waiting states, and this ensure those have been reset/incremented ## Testing performed to validate your change - Unit tests
udpatil
pushed a commit
that referenced
this pull request
Apr 16, 2024
…rt tracing when using OCC (#478) ## Describe your changes and provide context This brings in an interface that can be set on `DeliverTxEntry` and hooks into the `scheduler` so it call's the necessary tracer callbacks when required. Refer to `types/tx_tracer.go` for extra details about the patch. ## Testing performed to validate your change --------- Co-authored-by: Steven Landers <[email protected]>
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
…rt tracing when using OCC (#478) ## Describe your changes and provide context This brings in an interface that can be set on `DeliverTxEntry` and hooks into the `scheduler` so it call's the necessary tracer callbacks when required. Refer to `types/tx_tracer.go` for extra details about the patch. ## Testing performed to validate your change --------- Co-authored-by: Steven Landers <[email protected]>
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
…rt tracing when using OCC (#478) ## Describe your changes and provide context This brings in an interface that can be set on `DeliverTxEntry` and hooks into the `scheduler` so it call's the necessary tracer callbacks when required. Refer to `types/tx_tracer.go` for extra details about the patch. ## Testing performed to validate your change --------- Co-authored-by: Steven Landers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This brings in an interface that can be set on
DeliverTxEntry
and hooks into thescheduler
so it call's the necessary tracer callbacks when required.Refer to
types/tx_tracer.go
for extra details about the patch.Testing performed to validate your change