Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TxTracer to DeliverTxEntry which is the first step to support tracing when using OCC #478

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

maoueh
Copy link
Contributor

@maoueh maoueh commented Mar 27, 2024

Describe your changes and provide context

This brings in an interface that can be set on DeliverTxEntry and hooks into the scheduler so it call's the necessary tracer callbacks when required.

Refer to types/tx_tracer.go for extra details about the patch.

Testing performed to validate your change

@maoueh maoueh force-pushed the feature/occ-tx-tracer branch from 8e22d1d to c7d62bc Compare March 29, 2024 13:59
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (ed1bd73) to head (263f52f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2     #478      +/-   ##
==========================================
+ Coverage   55.34%   55.35%   +0.01%     
==========================================
  Files         629      629              
  Lines       53948    53963      +15     
==========================================
+ Hits        29857    29872      +15     
  Misses      21957    21957              
  Partials     2134     2134              
Files Coverage Δ
tasks/scheduler.go 90.81% <100.00%> (+0.37%) ⬆️

tasks/scheduler.go Outdated Show resolved Hide resolved
…rt tracing when using OCC

This brings in an interface that can be set on `DeliverTxEntry` and hooks into the `scheduler` so it call's the necessary tracer callbacks when required.

Refer to `types/tx_tracer.go` for extra details about the patch.
@maoueh maoueh force-pushed the feature/occ-tx-tracer branch from b0b6e4f to 92e6425 Compare March 29, 2024 15:31
@maoueh
Copy link
Contributor Author

maoueh commented Mar 29, 2024

#477 Must be merged first other unit test of this PR are not going to pass properly.

## Describe your changes and provide context
- Some tasks could be in waiting states, and this ensure those have been
reset/incremented

## Testing performed to validate your change
- Unit tests
@stevenlanders stevenlanders merged commit 8b8b573 into sei-protocol:seiv2 Mar 29, 2024
13 checks passed
@maoueh maoueh deleted the feature/occ-tx-tracer branch March 29, 2024 18:00
udpatil pushed a commit that referenced this pull request Apr 16, 2024
…rt tracing when using OCC (#478)

## Describe your changes and provide context

This brings in an interface that can be set on `DeliverTxEntry` and
hooks into the `scheduler` so it call's the necessary tracer callbacks
when required.

Refer to `types/tx_tracer.go` for extra details about the patch.

## Testing performed to validate your change

---------

Co-authored-by: Steven Landers <[email protected]>
udpatil pushed a commit that referenced this pull request Apr 19, 2024
…rt tracing when using OCC (#478)

## Describe your changes and provide context

This brings in an interface that can be set on `DeliverTxEntry` and
hooks into the `scheduler` so it call's the necessary tracer callbacks
when required.

Refer to `types/tx_tracer.go` for extra details about the patch.

## Testing performed to validate your change

---------

Co-authored-by: Steven Landers <[email protected]>
udpatil pushed a commit that referenced this pull request Apr 19, 2024
…rt tracing when using OCC (#478)

## Describe your changes and provide context

This brings in an interface that can be set on `DeliverTxEntry` and
hooks into the `scheduler` so it call's the necessary tracer callbacks
when required.

Refer to `types/tx_tracer.go` for extra details about the patch.

## Testing performed to validate your change

---------

Co-authored-by: Steven Landers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants